Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SETINFO Format #203

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Fix SETINFO Format #203

merged 6 commits into from
Dec 18, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Nov 5, 2023

Closes #204

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (92e3d82) 94.14% compared to head (8d216ef) 80.86%.

Files Patch % Lines
src/NRedisStack/CoreCommands/CoreCommandsAsync.cs 25.00% 2 Missing and 1 partial ⚠️
src/NRedisStack/CoreCommands/CoreCommands.cs 33.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #203       +/-   ##
===========================================
- Coverage   94.14%   80.86%   -13.29%     
===========================================
  Files          85       85               
  Lines        5173     5178        +5     
  Branches      486      488        +2     
===========================================
- Hits         4870     4187      -683     
- Misses        177      890      +713     
+ Partials      126      101       -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chayim chayim added the enhancement New feature or request label Nov 26, 2023
@shacharPash
Copy link
Contributor Author

@chayim I think we will close this PR, this issue will be closed in #208

@shacharPash shacharPash marked this pull request as ready for review December 18, 2023 13:29
@shacharPash shacharPash changed the title Change SETINFO Process to Make Mocking Easier Fix SETINFO Format Dec 18, 2023
@shacharPash shacharPash merged commit b05d08b into master Dec 18, 2023
15 checks passed
@shacharPash shacharPash deleted the Issue202/MockSetup branch December 18, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRedisStack doesn't follow lib-name format used in other clients
3 participants