(feat): Suggestions from Pull Request

reecetech · May 20, 2024 · dfc92fe · dfc92fe
1 parent 382cecc
commit dfc92fe
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/configs/ubuntu.yml b/configs/ubuntu.yml
@@ -14,4 +14,4 @@ devices:
     mountPoint: /mnt/bar
     user: ubuntu
     group: ubuntu
-    permissions: 755
+    permissions: 755
diff --git a/internal/config/modifier.go b/internal/config/modifier.go
@@ -70,9 +70,8 @@ func NewLvmModifier() *LvmModifier {
 }
 
 func (lm *LvmModifier) Modify(c *Config) error {
-	// Fetch a copy of the original keys as we are updating
-	// the config in-place and it is unsafe to iterate over it
-	// directly
+	// Fetch a copy of the original keys as we are updating the
+	// config in-place and it is unsafe to iterate over it directly
 	keys := make([]string, len(c.Devices))
 	for name := range c.Devices {
 		keys = append(keys, name)

diff --git a/internal/datastructures/lvm_graph.go b/internal/datastructures/lvm_graph.go
@@ -197,6 +197,7 @@ func (lg *LvmGraph) GetLogicalVolume(name string, vg string) (*LvmNode, error) {
 func (lg *LvmGraph) GetParents(node *LvmNode, state LvmNodeCategory) []*LvmNode {
 	parents := []*LvmNode{}
 	for _, p := range node.parents {
+		// Bitmasking to check if the parent nodes is of the desired category
 		if int32(p.State)&int32(state) > 0 {
 			parents = append(parents, p)
 		}
@@ -207,6 +208,7 @@ func (lg *LvmGraph) GetParents(node *LvmNode, state LvmNodeCategory) []*LvmNode
 func (lg *LvmGraph) GetChildren(node *LvmNode, state LvmNodeCategory) []*LvmNode {
 	children := []*LvmNode{}
 	for _, c := range node.children {
+		// Bitmasking to check if children nodes is of the desired category
 		if int32(c.State)&int32(state) > 0 {
 			children = append(children, c)
 		}