(feat): Resize Physical Volume #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasith-kg
force-pushed
the
feature/lvm-resize
branch
from
8525aac to
09cb4f2
Compare
HSPm
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the original
resizeFsattribute to assess whether the Physical Volume needs to be resized. We determine this by comparing the size of the Physical Volume with the underlying Block Device. I also expanded theLvmGraphdata structure to store size information of the various LVM objects. This will be useful when we start adding logic to detect whether a logical volume needs to be resizedI want to release another major version of
ebs-bootstrapwhere we renameresizeFstoresize. In my opinion, if you want to resize a filesystem, you probably want to have the underlying Physical Volumes and Logical Volumes extended