Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the ability to detect whether a Logical Volume needs to be resized. Rather than following the
threshold
approach from Physical Volumes, we implement atolerance
approach.When
ebs-bootstrap
creates a Logical Volume, it specifies how much percent of the Volume Group it should use. This value is retrieved fromlvmConsumption
.When we check how much percent of the Volume Group that the Logical Volume has consumed, we see that it is not exactly the value that we specified.
Process
(45 ± 0.1)%
(45 - 0.1)%
(45 + 0.1)%
. This would imply that somebody is attempting to shrink a logical volume. This is a disallowed operation