(feat): Refactor Resize Capabilities #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will create a
v2
. I am decommissioningresizeThreshold
, renamingresizeFs
toresize
and converting the data type oflvmConsumption
fromint
touint64
FAQ
resizeThreshold
?lvm2
, I realised that hard-coding a sensible threshold amount was more scalable than creating a configurable threshold for each resize categorylvResizeThreshold
,vgResizeThreshold
andresizeThreshold
!resizeThreshold
to a default value of99.999%
ExplanationresizeFs
toresize
?resizeFs
to determine whether a Physical Volume and Logical Volume needs to be resized.xfs
file systemresizeFs
toresize
, I keep it concise and relevant to how it is being used throughout the applicationlvmConsumption
from int touint64
?lvmConsumption
represents a percent value between0
and100
uint16
oruint32
because they are not supported by theflags
librarylayer
tobackend
package?lvm
development, I was reminded that the purpose of thelayer
was to act as the orchestratorlayer
backend.ShouldResize(device)
rather thanbackend.ShouldResize(device, threshold)
resizeFs
toresize
resizeThreshold
ebs-bootstrap