Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Add fallback non-assigned block device mapping #8

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

lasith-kg
Copy link
Collaborator

@lasith-kg lasith-kg commented Feb 12, 2024

ebs-bootstrap should not fail if an Instance Store volume with an unassigned block device mapping is attached to the EC2 Instance. Especially if this Instance Store volume is not mentioned in the configuration file. Therefore, I have added a fallback clause where in if the Vendor Specific information fails to expose a block device mapping, it will now fallback to a safer option, rather than erroring out.

# Before
Vendor Specific: ephemeral0:none -> (Error) ❌

# After
Vendor Specific: ephemeral0:none -> /dev/ephemeral0

I've also updated the testing frame work to remove the need to explicitly mention what Vendor Specific Padding to use in the NVMe test cases

@lasith-kg lasith-kg enabled auto-merge February 12, 2024 03:27
@lasith-kg lasith-kg disabled auto-merge February 12, 2024 03:27
@lasith-kg lasith-kg merged commit e60d980 into main Feb 12, 2024
3 checks passed
@lasith-kg lasith-kg deleted the fix/missing-block-device branch February 12, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants