Ignore git-clean failures #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some restylers create files that we do not have permission to clean up. I might've expected that to always be the case, since they run in a container as `root`, but many restylers create files we can and do clean up. Attempting it and ignoring permissions errors seems fine; it was best-effort anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some restylers create files that we do not have permission to clean up.
I might've expected that to always be the case, since they run in a
container as
root, but many restylers create files we can and do cleanup. Attempting it and ignoring permissions errors seems fine; it was
best-effort anyway.