Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node in npm-groovy-lint #839

Merged
merged 3 commits into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions _tools/restylers/src/Restylers/Test.hs
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ testRestylers pull restylers hspecArgs = do
, ["--no-commit"]
, ["--no-clean"]
, ["--no-pull" | not pull]
, ["--restyler-memory", "512m"]
, ["."]
]

Expand Down
2 changes: 1 addition & 1 deletion npm-groovy-lint/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:21.7-slim
FROM node:22.11-slim
LABEL maintainer="Pat Brisbin <[email protected]>"
ENV LANG en_US.UTF-8
RUN mkdir -p /app
Expand Down
19 changes: 15 additions & 4 deletions npm-groovy-lint/npm-groovy-lint
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
#!/bin/sh
# If you use --failon=none, that doesn't just prevent the non-zero exit code, oh
# no, it disables all fixing and formatting too! So we need this dumb wrapper
# that just ignores the exit code instead.
/app/node_modules/.bin/npm-groovy-lint "$@" || true
/app/node_modules/.bin/npm-groovy-lint "$@"
ret=$?

case $ret in
1)
# This tool lacks a --no-exit-code type of option, and it exits 1 when it
# has found/fixed issues. So we'll exit 0 on that case.
exit 0
;;
*)
# Any other code will be respected, because there is a few that have meaning
# (e.g. 9 for out of memory)
exit $ret
;;
esac
Loading