Fix warnings and error with release name

richiksc · Dec 6, 2020 · 42af272 · 42af272
1 parent 09db92a
commit 42af272
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -13,6 +13,8 @@ jobs:
       ARM: aarch64-apple-darwin
     steps:
       - uses: actions/checkout@v2
+      - name: Set Release Version
+        run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
       - name: Install Rust beta
         uses: actions-rs/toolchain@v1
         with:
@@ -42,7 +44,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
         with:
           tag_name: ${{ github.ref }}
-          release_name: badlogvis ${{ github.ref }}
+          name: badlogvis ${{ env.RELEASE_VERSION }}
           draft: false
           prerelease: false
           files: |
@@ -55,6 +57,8 @@ jobs:
       WIN: x86_64-pc-windows-gnu
     steps:
       - uses: actions/checkout@v2
+      - name: Set Release Version
+        run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
       - name: Install Rust beta
         uses: actions-rs/toolchain@v1
         with:
@@ -80,7 +84,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
         with:
           tag_name: ${{ github.ref }}
-          release_name: badlogvis ${{ github.ref }}
+          name: badlogvis ${{ env.RELEASE_VERSION }}
           draft: false
           prerelease: false
           files: |

diff --git a/src/graph.rs b/src/graph.rs
@@ -212,7 +212,7 @@ impl Graph {
 
                         let (_, name_base) = util::split_name(&name);
 
-                        let mut unit = format!("{}/{}", topic.unit, xaxis.unit);
+                        let unit = format!("{}/{}", topic.unit, xaxis.unit);
 
                         let series = gen_series(topic.data.clone(), name_base).differentiate();
 
@@ -230,7 +230,7 @@ impl Graph {
 
                         let (_, name_base) = util::split_name(&name);
 
-                        let mut unit = format!("{}*{}", topic.unit, xaxis.unit);
+                        let unit = format!("{}*{}", topic.unit, xaxis.unit);
 
                         let (series, _total_sum) =
                             gen_series(topic.data.clone(), name_base).integrate();