-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project breakdown page #6310
base: main
Are you sure you want to change the base?
Conversation
AdityaHegde
commented
Dec 19, 2024
•
edited
Loading
edited
- Add subpage for project breakdown
- Add link in billings settings page
- Add breadcrumb for project breakdown page
- To test locally use this: https://github.com/rilldata/synthetic-rill-cloud-metrics
- Add a devtool command for the above so that local setup is easier.
- UX feedback
- Error page when metrics project is not configured or is down.
- Breadcrumbs situation.
- Measure/dimension labels for the dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the https://github.com/rilldata/synthetic-rill-cloud-metrics repository:
- I'm struggling to follow the instructions to generate the data. It doesn't seem like the
go run ./cli main.go
instruction is accurate. - In the PR to setup Cloud e2e tests, I'm putting test GitHub repositories in
web-admin/tests/setup/git/repos
. Can you add a script inweb-admin/tests/setup
that pulls the repo into that location & runs the command to generate the data? - Can we make this repo public? Any contributors to the Rill codebase should be able to test this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This is on the back burner for getting design. Lets do that in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a minimum, could you put the error in basic red text? I was confused until I opened up the browser console
@ericpgreen2 The repo was just a mirror of code I had during development. We are looking at ways to make it simple for local testing. Most probably a |