Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project breakdown page #6310

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Dec 19, 2024

  • Add subpage for project breakdown
  • Add link in billings settings page
  • Add breadcrumb for project breakdown page
  • To test locally use this: https://github.com/rilldata/synthetic-rill-cloud-metrics
  • Add a devtool command for the above so that local setup is easier.
  • UX feedback
    • Error page when metrics project is not configured or is down.
    • Breadcrumbs situation.
    • Measure/dimension labels for the dashboard

@AdityaHegde AdityaHegde marked this pull request as ready for review December 23, 2024 15:26
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the https://github.com/rilldata/synthetic-rill-cloud-metrics repository:

  1. I'm struggling to follow the instructions to generate the data. It doesn't seem like the go run ./cli main.go instruction is accurate.
  2. In the PR to setup Cloud e2e tests, I'm putting test GitHub repositories in web-admin/tests/setup/git/repos. Can you add a script in web-admin/tests/setup that pulls the repo into that location & runs the command to generate the data?
  3. Can we make this repo public? Any contributors to the Rill codebase should be able to test this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add error handling for the billing/metrics-project-credentials API request. I know this "metrics project not configured" error should not happen in production, but if there's any error, it should be displayed on the screen.

image

Copy link
Collaborator Author

@AdityaHegde AdityaHegde Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This is on the back burner for getting design. Lets do that in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a minimum, could you put the error in basic red text? I was confused until I opened up the browser console

@AdityaHegde
Copy link
Collaborator Author

@ericpgreen2 The repo was just a mirror of code I had during development. We are looking at ways to make it simple for local testing. Most probably a devtool command will be added that can be reused for E2E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants