doc team edits #16
Open
doc team edits #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kersten Richter <[email protected]>
Signed-off-by: Kersten Richter <[email protected]>
kersten1
commented
Nov 22, 2024
| @@ -3,5 +3,5 @@ | |||
| The RISC-V IO Mapping Table (RIMT) provides information about the RISC-V IOMMU | |||
| cite:[IOMMU-SPEC] and the relationship between the IO topology and the IOMMU in | |||
| ACPI cite:[ACPI-SPEC] based RISC-V platforms. The RIMT identifies which | |||
| components are behind IOMMU and how they are connected together. RISC-V IOMMU | |||
| components are backing IOMMU and how they are connected together. RISC-V IOMMU | |||
There was a problem hiding this comment.
"behind" is more directional to me so I suggest "backing". Please let me know if you want to discuss this farther. Maybe there is a third word that is better?
|
Very minor grammar comments. Whenever you use "which", it must have a comma before it. "which" is used for extra information that isn't really required. "that" is information that is important to the sentence. Otherwise, pretty clear and straightforward. Let me know if you want to discuss any of this. These are suggestions and not red pen marks that must be followed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.