Fix "return" key in disassembler widget (#3090) and graph jumps #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whol-hoopa
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
|
@whol-hoopa the failure is unrelated, it's something changed on Rizin side, see #3147 |
whol-hoopa
force-pushed
the
whola-graph_jumps_disassembly_jumps
branch
from
c7f5ad5 to
16b195a
Compare
Fix graph jumps
whol-hoopa
force-pushed
the
whola-graph_jumps_disassembly_jumps
branch
from
16b195a to
5ed0f33
Compare
3 tasks
|
Should this pull request be broken down to smaller pull requests? It changes the graph and disassembly. |
|
@whol-hoopa should be fine as is. @thestr4ng3r could you please take a look? |
|
@karliss could you give a look? |
XVilka
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the return key in disassembler
Fix graph jumps
Your checklist for this pull request
Detailed description
I fixed the problem with the disassembler not jumping when the instruction is a jump conditional
The graph also had a similar problem with not jumping when the instruction is a conditional jump so I also fixed the graph jumps since it also used similar functions to when the disassembler wants to jump.
Test plan (required)
The test can be performed on "jne" instruction and other conditonal jump instructions.
The test should also be performed on the disassembler graph.
Closing issues
closes #3140
closes #3090