Skip to content

Commit

Permalink
[chore][docs/rfc] Add text regarding conversations (open-telemetry#11738
Browse files Browse the repository at this point in the history
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Based on the experience of this process going through once, I am
suggesting we make the following changes:

1. Require announcing the final comment period via a comment and on the
#otel-collector-dev channel.
2. Require that all conversations are resolved. Allow RFC author to
resolve any conversation, but require them to leave a comment explaining
why

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes open-telemetry#11737

Co-authored-by: Alex Boten <[email protected]>
  • Loading branch information
mx-psi and codeboten authored Dec 4, 2024
1 parent 4ed80bb commit bc7af62
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions docs/rfcs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,19 @@ We use a [Lazy Consensus](https://www.apache.org/foundation/glossary.html#LazyCo
1. *Quorum*: For an RFC to be mergeable, it needs to have at least **two approvals** from the
approvers set as well as approvals from any additional stakeholders.
2. *Waiting period*: Maintainers need to announce their intent to merge the RFC with a GitHub
comment. They will need to add a `rfc:final-comment-period` label to the PR and wait for at least
**4 business days** after making the announcement to merge the RFC.
comment. They will need to add a `rfc:final-comment-period` label to the PR, comment on the PR
and note the final comment period in the #otel-collector-dev CNCF Slack channel, and wait for at
least **4 business days** after making the announcement to merge the RFC.
3. *Objections*: Objections should be communicated as a 'request changes' review. All objections
must be addressed before merging an RFC. If addressing an objection does not appear feasible, any
maintainer may call for a vote to be made on the objection (see below). This will be signified by
adding a `rfc:vote-needed` label to the PR. The voting result is binding and a maintainer can
drop any 'request changes' reviews based on the vote results or consensus.
4. *Modifications*: Non-trivial modifications to an RFC reset the waiting period. RFC authors must
re-request any approving, comment, or 'request changes' reviews if the RFC has been modified significantly.
5. *All conversations are resolved*: All Github conversations on the PR must be marked as resolved
before merging. The RFC author may resolve conversations at their discretion, but they must
explain in the conversation thread why they believe it is appropriate to do so.

### Voting

Expand Down

0 comments on commit bc7af62

Please sign in to comment.