Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fading sides #54

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

EnricoMonese
Copy link
Contributor

This one is a bit specific. It allows to add a straight segment that fades out at the beginning and at the end of the graph.
The amount is customizable and can be set directly in the xml. fadeLength
fade out sides

The fading segments possibly do not respect padding, but it's an easy fix.

@naturalwarren
Copy link
Contributor

Gimme! I would totally use an attribute like this.

Doesn't add much to the surface area of the API either.

@EnricoMonese
Copy link
Contributor Author

Better fading
better fade
Using the line color instead of fading to Color.TRANSPARENT to avoid darkening as it fades out

@danh32
Copy link
Contributor

danh32 commented Apr 21, 2018

Hey @EnricoMonese, so sorry for sitting on this for so long! This is a really beautiful effect. The bad news is, I think it's a little specific to merge into Spark 1.0. The good news is, I'm starting to formulate some ideas for Spark 2.0 that will make it much easier to include more specific effects like this in a generic way. Sorry for asking you to wait a bit longer, but I'd love to get this in after the 2.0 changes happen.

@danh32 danh32 mentioned this pull request Apr 21, 2018
@EnricoMonese
Copy link
Contributor Author

Don't worry, we're using our own custom fork anyway :) Since the work was already done I just made the PRs so you could easily add what you like

@danh32
Copy link
Contributor

danh32 commented Apr 21, 2018

Ok, cool! Really appreciate you sharing these effects! I'm gonna leave these open for now, and will hopefully have a place for these to go in Spark 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants