-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fading sides #54
base: master
Are you sure you want to change the base?
Conversation
Gimme! I would totally use an attribute like this. Doesn't add much to the surface area of the API either. |
Hey @EnricoMonese, so sorry for sitting on this for so long! This is a really beautiful effect. The bad news is, I think it's a little specific to merge into Spark 1.0. The good news is, I'm starting to formulate some ideas for Spark 2.0 that will make it much easier to include more specific effects like this in a generic way. Sorry for asking you to wait a bit longer, but I'd love to get this in after the 2.0 changes happen. |
Don't worry, we're using our own custom fork anyway :) Since the work was already done I just made the PRs so you could easily add what you like |
Ok, cool! Really appreciate you sharing these effects! I'm gonna leave these open for now, and will hopefully have a place for these to go in Spark 2.0. |
This one is a bit specific. It allows to add a straight segment that fades out at the beginning and at the end of the graph.
The amount is customizable and can be set directly in the xml.
fadeLength
The fading segments possibly do not respect padding, but it's an easy fix.