You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
RocketNetworkPrices.submitPrices doesn't enforce the configured frequency despite the setting existing #342
The frequency setting itself exists (network.submit.prices.frequency, defaults to 1 day) and is exposed through the settings interface at RocketDAOProtocolSettingsNetwork.sol:166, it's just never enforced in the submit function. So oracles could push price updates as fast as the consensus threshold allows regardless of what the frequency setting says.
In practice this is mitigated by the oracle consensus requirement (need >=50% of trusted nodes to agree), so it's not something an attacker can exploit unilaterally. But the setting is misleading anyone configuring it expects it to be enforced.
The fix would be adding the same frequency check pattern from _updateBalances into submitPrices before allowing the update to go through.
Activity