Skip to content

Use multicall in GetNodeMinipoolDetails - #1235

Open
thomaspanf wants to merge 1 commit into
masterfrom
node-status-multicall
Open

thomaspanf wants to merge 1 commit into
masterfrom
node-status-multicall

Conversation

@thomaspanf

@thomaspanf thomaspanf commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Same flavor of improvement as #1209

time rocketpool node status tested on hoodi

Node Megapool validators Minipools Before After
0x33B0970710da71C6CEd0f305a70350CFE930fc10 2000 1400 16.43s 2.4s
0xaE1173b1fDB4B2B008A72E7Ce89670caD3fF3E82 1 12 0.76s 0.55s
0xE8325F5f4486c2FF2AC7B522Fbc9eB249d46C936 0 2 0.58s 0.62s

@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool/api/minipool 0.05% (-0.00%) 👎
github.com/rocket-pool/smartnode/rocketpool/api/node 2.01% (+0.01%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool/api/minipool/status.go 0.00% (ø) 1433 (+62) 0 1433 (+62)
github.com/rocket-pool/smartnode/rocketpool/api/minipool/utils.go 0.00% (ø) 7864 (+185) 0 7864 (+185)
github.com/rocket-pool/smartnode/rocketpool/api/node/status.go 0.00% (ø) 11758 (-927) 0 11758 (-927)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant