Fix macos ping flags closes #28 #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also verified that this fixes the issue in macOS. |
pfontain
approved these changes
May 20, 2022
|
I've been looking for a solution in mac, this PR actually resolves my problem, you guys should resolve conflicts and merge this PR ASAP |
|
Just confirming that this small (3 Line) fix approved above does work. For anyone else wondering, you can modify the template makefile found in the Add the lines found above that @pfontain approved. For reference the approval can be found here: https://github.com/rokudev/samples/pull/29/files/3139c3fa6a43f137720b075c8818cc4c2d2a7f91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #28
I confirmed with an example that this does indeed fix the problem on macOS.