-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoR v8 and Ruby v3.3 support #1171
Draft
mateuszgorniak
wants to merge
14
commits into
rollbar:master
Choose a base branch
from
mateuszgorniak:rails-v8-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mentioned Rails and Ruby versions are not a part of workflow matrix anymore
mateuszgorniak
force-pushed
the
rails-v8-support
branch
from
January 9, 2025 00:31
b94f4e2
to
fdf1fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This pull request introduces updates to the CI configuration, Gemfile, and related gemfiles to support newer versions of Ruby and Rails, along with various minor code and configuration improvements.
Changes:
.github/workflows/ci.yml
to include newer releases.3.3.6
.appraisal
gem, which is no longer used in the current CI setup.recursive_current_user
method in home_controller.rb.show_exceptions
configuration in the test environment based on Rails version (details here).spec_helper.rb
to use the new syntax forMultiFormatter.new
.Type of change
Checklists
Development
Code review