Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoR v8 and Ruby v3.3 support #1171

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

mateuszgorniak
Copy link

@mateuszgorniak mateuszgorniak commented Jan 9, 2025

Description of the change

This pull request introduces updates to the CI configuration, Gemfile, and related gemfiles to support newer versions of Ruby and Rails, along with various minor code and configuration improvements.

Changes:

  • CI Configuration:
    • Updated Ruby versions in .github/workflows/ci.yml to include newer releases.
    • Added support for Rails 8.0 and 7.2, adjusting gem dependencies to ensure the updated CI matrix functions correctly.
    • Updated GitHub Actions - this way risk of some urgent adjustments because of not supported node version has been decreased.
  • Gemfile and Dependencies:
    • Updated the Ruby version in Gemfile to 3.3.6.
    • Removed outdated Rails versions from Appraisals.
    • Eliminated the appraisal gem, which is no longer used in the current CI setup.
  • Typo Fixes: Fixed a typo in the recursive_current_user method in home_controller.rb.
  • Deprecations and Warnings:
    • Added proper eager loading configurations for all environments.
    • Adjusted the show_exceptions configuration in the test environment based on Rails version (details here).
  • Coverage Tooling: Updated the simplecov setup in spec_helper.rb to use the new syntax for MultiFormatter.new .
  • Code Cleanup: Removed outdated conditions for unsupported Ruby/Rails versions to simplify the codebase.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@mateuszgorniak mateuszgorniak changed the title RoR v8 and support RoR v8 and Ruby v3.3 support Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant