Allow n_segments to be > 1, fix #560

ropensci · May 1, 2024 · dba1894 · dba1894
1 parent dd21f41
commit dba1894
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/R/linefuns.R b/R/linefuns.R
@@ -172,7 +172,7 @@ line_midpoint <- function(l, tolerance = NULL) {
 #' @export
 #' @examples
 #' library(sf)
-#' l <- routes_fast_sf[2:4, ]
+#' l <- routes_fast_sf[2:4, "ID"]
 #' l_seg_multi <- line_segment(l, segment_length = 1000, use_rsgeo = FALSE)
 #' l_seg_n <- line_segment(l, n_segments = 2)
 #' l_seg_n <- line_segment(l, n_segments = c(1:3))
@@ -202,7 +202,7 @@ line_segment <- function(
     use_rsgeo = NULL,
     debug_mode = FALSE) {
   # Defensive programming:
-  if (is.na(segment_length) && is.na(n_segments)) {
+  if (any(is.na(segment_length)) && any(is.na(n_segments))) {
     rlang::abort(
       "segment_length or n_segments must be set.",
       call = rlang::caller_env()
@@ -219,7 +219,7 @@ line_segment.sf <- function(
     debug_mode = FALSE
   ) {
   # Get n_segments if not provided:
-  if (is.na(n_segments)) {
+  if (all(is.na(n_segments))) {
     segment_lengths <- as.numeric(sf::st_length(l))
     n_segments <- n_segments(segment_lengths, segment_length)
   } else {

diff --git a/man/line_segment.Rd b/man/line_segment.Rd