Skip to content

Commit

Permalink
Fix #1244
Browse files Browse the repository at this point in the history
  • Loading branch information
wlandau committed Apr 5, 2024
1 parent c8165b4 commit 98490c1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,7 @@ importFrom(tidyselect,starts_with)
importFrom(tools,file_path_sans_ext)
importFrom(utils,browseURL)
importFrom(utils,capture.output)
importFrom(utils,compareVersion)
importFrom(utils,data)
importFrom(utils,globalVariables)
importFrom(utils,head)
Expand Down
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

## Invalidating changes

* Use `secretbase::siphash13()` instead of `digest(algo = "xxhash64", serializationVersion = 3)` so hashes of in-memory objects no longer depend on serialization version 3 headers (#1244, @shikokuchuo). Unfortunately, pipelines built with earlier versions of `targets` will need to rerun. However, `tar_make()` now prompts the user so a decision can be made to continue or downgrade in the interactive case.
* Use `secretbase::siphash13()` instead of `digest(algo = "xxhash64", serializationVersion = 3)` so hashes of in-memory objects no longer depend on serialization version 3 headers (#1244, @shikokuchuo). Unfortunately, pipelines built with earlier versions of `targets` will need to rerun.

## Other improvements

* Inform and prompt the user when the pipeline was built with an old version of `targets` and changes to the package will cause the current work to rerun (#1244). For the `tar_make*()` functions, `utils::menu()` prompts the user to give people a chance to downgrade if necessary.
* For type safety in the internal database class, read all columns as character vectors in `data.table::fread()`, then convert them to the correct types afterwards.

# targets 1.6.0
Expand Down
4 changes: 2 additions & 2 deletions R/tar_package.R
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
#' @importFrom tidyselect all_of any_of contains ends_with everything
#' last_col matches num_range one_of starts_with
#' @importFrom tools file_path_sans_ext
#' @importFrom utils browseURL capture.output data globalVariables head menu
#' packageVersion stack tail
#' @importFrom utils browseURL capture.output compareVersion data
#' globalVariables head menu packageVersion stack tail
#' @importFrom vctrs vec_c vec_rbind vec_size vec_slice
#' @importFrom yaml read_yaml
NULL
Expand Down

0 comments on commit 98490c1

Please sign in to comment.