-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ControllerMock #1948 #1990
Remove ControllerMock #1948 #1990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1990 +/- ##
==========================================
- Coverage 89.33% 89.32% -0.02%
==========================================
Files 130 130
Lines 14516 14515 -1
Branches 1258 1258
==========================================
- Hits 12968 12965 -3
+ Misses 1083 1082 -1
- Partials 465 468 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
(cherry picked from commit a04416d)
I was looking at the #1948, and indeed this is an overload and not a overrided method. There is no update method that takes zero arguments. Nevertheless, I've checked and this code is not used in ros2_control nor in any other ros2_control repo. I think this might be deleted.