Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathCompleteGoalChecker documentation and related changes #620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josephduchesne
Copy link

  • Added documentation for PathCompleteGoalChecker
  • Added migration notes for GoalChecker plugin interface changes
  • Made PathCompleteGoalChecker the default in examples.

This should be paired with ros-navigation/navigation2#4789

…in interface changes. Made PathCompleteGoalChecker the default in examples.

Signed-off-by: Joseph Duchesne <[email protected]>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of updates - I think you're missing a page 😉

There's also a merge conflict now

@@ -240,6 +240,7 @@ Provided Plugins
nav2_controller-plugins/pose_progress_checker.rst
nav2_controller-plugins/simple_goal_checker.rst
nav2_controller-plugins/stopped_goal_checker.rst
nav2_controller-plugins/path_complete_goal_checker.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you committed this page 🙃


New (default) Goal Checker Plugin: PathCompleteGoalChecker
********************************************************
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly, the line length has to match the title for rst to properly render -- please add **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants