Repository navigation
usage: the in-memory ring adds figures across billing units #1188
Description
Activity
Already fixed on main by 8776e32 ("Report billing units from the usage ring, and per agent"), merged in #1195 on 2026-09-30. That PR closed only #1182, so this one stayed open.
The fix is the one this issue sketched:
- Each ring bucket keeps a per-unit series. It is
bucket.byCurrencyincore/cost/usage/usage.go, keyed by the record's unit using the ledger's rule (pricing.UnitOf). Aggregator.Snapshotfills inCurrenciesfrom the units behind every priced or saved figure, asledger.CurrenciesIndoes.- The ring serves
group=currency. The downgrade togroup: "none"is gone.
As a result, a ring-served window (
agentop cost --window 1h, or any window on a deployment with no cost ledger) no longer adds figures across units.docs/pricing.mdnow scopes "figures in different units are never added" to both the ledger and the ring.These tests in
core/cost/usage/currency_test.gocover it:TestSnapshot_TheRingBreaksTotalsDownByUnit,TestSnapshot_TheRingNamesItsUnitsUngroupedandTestSnapshot_TheRingReportsDollarsLikeTheLedger.Assisted-By: Claude (Anthropic AI) noreply@anthropic.com
- Each ring bucket keeps a per-unit series. It is
- moved this from New/ToDo to Done in Rossoctl Issue Prioritization
on Oct 2, 2026
Split out of #1153, from its peer review.
The in-memory ring (
core/cost/usage) keeps no unit per figure:buckethas no currency series, andAggregator.Snapshotnever setsSnapshot.Currencies. So a window it serves — a duration such asabctl cost --window 1h, or any window when no cost ledger is configured, which is the Kubernetes deployment — adds every unit's figures into oneTotals.CostMicros.abctl costprints that under$, because an absentcurrencieslist reads as the default.#1153 makes the ring say what it cannot do rather than track units:
group=currencyis answered withgroup: "none", which abctl reports as a downgrade, anddocs/pricing.mdscopes "figures in different units are never added" to ledger windows. The ledger path separates units end to end.Shape of a fix
The ledger writer takes its unit from
pricing.Resolver.CurrencyFor(host, model). Giving the aggregator the same resolver would let it key a currency series per bucket and computeCurrenciesthe wayledger.CurrenciesIndoes — at which point the ring can servegroup=currencytoo, and the downgrade at the top ofAggregator.Snapshotgoes.Reachable set
A configured non-USD
unit:and a ring-served window. A deployment with nounit:configured is unaffected: every figure it has is USD.Assisted-By: Claude (Anthropic AI) noreply@anthropic.com