Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Fixing build issue described in: https://github.com/libp2p/rust-libp2p/issues/2231 #475

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

karim-agha
Copy link
Contributor

When including rust-ipfs as a dependency in any crate, it fails with the following error:

error: failed to select a version for the requirement `aesni = "^0.7"`
candidate versions found which didn't match: 0.99.99, 0.10.0, 0.9.0, ...
location searched: crates.io index
required by package `aes v0.4.0`
    ... which is depended on by `aes-gcm v0.6.0`
    ... which is depended on by `snow v0.7.1`
    ... which is depended on by `libp2p-noise v0.30.0 (/home/alexander/dev/misc/rust-libp2p/transports/noise)`
    ... which is depended on by `libp2p v0.37.1 (/home/alexander/dev/misc/rust-libp2p)`
    ... which is depended on by `libp2p-relay v0.2.0 (/home/alexander/dev/misc/rust-libp2p/protocols/relay)`

This fix updates the libp2p version into one that has a fix for this dependency and now it compiles fine

    When including rust-ipfs as a dependency in any crate, it fails with the following error:

    ```
    error: failed to select a version for the requirement `aesni = "^0.7"`
    candidate versions found which didn't match: 0.99.99, 0.10.0, 0.9.0, ...
    location searched: crates.io index
    required by package `aes v0.4.0`
        ... which is depended on by `aes-gcm v0.6.0`
        ... which is depended on by `snow v0.7.1`
        ... which is depended on by `libp2p-noise v0.30.0 (/home/alexander/dev/misc/rust-libp2p/transports/noise)`
        ... which is depended on by `libp2p v0.37.1 (/home/alexander/dev/misc/rust-libp2p)`
        ... which is depended on by `libp2p-relay v0.2.0 (/home/alexander/dev/misc/rust-libp2p/protocols/relay)`
    ```

    This fix updates the libp2p version into one that has a fix for this dependency and now it compiles fine
@koivunej
Copy link
Collaborator

koivunej commented Nov 3, 2021

Thanks for this! I haven't been up to date with libp2p on this regard (trouble staying up with the many notifications) ... Do you have any ideas why didn't the cron job fail? I'm thinking it should had failed because we no longer have a Cargo.lock (see #470) but I am not entirely sure what's the root cause here.

Oki the root cause is at mxindens comment here but still surprised the cron build didn't start to fail. Well, maybe we'll need to consider the non-workspace crate in the CI after all.

@koivunej koivunej added the needs changelog Need to add a changelog entry (somewhere) label Nov 3, 2021
@koivunej
Copy link
Collaborator

koivunej commented Nov 3, 2021

Either way, thanks for this @karim-agha! Please let me know if you've gained some insight to the failure on #477.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 3, 2021

Build succeeded:

@bors bors bot merged commit ad3ab49 into rs-ipfs:master Nov 3, 2021
@karim-agha karim-agha deleted the libp2p-0.39.1 branch November 3, 2021 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs changelog Need to add a changelog entry (somewhere)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants