Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused method matcher for pending steps without reason #2015

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Dec 24, 2024

Before:

 find . -type f | xargs grep "pending_step_without_reason"
./lib/rubocop/cop/rspec/pending_without_reason.rb:        # @!method pending_step_without_reason?(node)
./lib/rubocop/cop/rspec/pending_without_reason.rb:        def_node_matcher :pending_step_without_reason?, <<~PATTERN

After:

 find . -type f | xargs grep "pending_step_without_reason"

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner December 24, 2024 14:54
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pirj pirj merged commit 5d768fe into master Dec 25, 2024
24 of 25 checks passed
@pirj pirj deleted the remove-unused branch December 25, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants