Repository navigation
Conversation
Instead of calling function pointers directly, route them through one place so that we can change the underlying implementation of the encoding objects without having to update callers.
Instead of housing a set of function pointers, make each encoding a different kind that knows how to check its own char width. Do this by introducing effectively tiny state machines that check multiple bytes at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shrinking the binary size a bit by sharing tables as much as possible and removing the function pointers. Also deduplicating the logic that builds the property checks versus the char width. This also is going to make it easier to implement the partial char work we need for regexps.