Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to formalize the "concern" syntax for MCPs #709

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Try to formalize the "concern" syntax for MCPs #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/compiler/mcp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,19 @@ The compiler-team repo issues are intended to be low traffic and used for proced

## How does one register as reviewer, register approval, or raise an objection?

These types of procedural comments can be left on the issue (it's also good to leave a message in Zulip). See the previous section.
These types of procedural comments can be left on the issue (it's also good to leave a message in Zulip). See the
previous section. To facilitate a machine parsable scanning of the concerns please use the following syntax to formally
register a concern:
```
@rustbot concern reason-for-concern

<long description of the concern>
```

And the following syntax to lift a concern when resolved:
```
@rustbot resolve reason-for-concern
```

## Who decides whether a concern is unresolved?

Expand Down