Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail about how to raise MCP concerns #1747

Merged

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Nov 13, 2023

During the weekly T-compiler triage meetings we list all MCPs in different stages of progress. Some of them are blocked on concerns not yet resolved. We would like to list these open concerns so that meeting attendees have a glance why an MCP is not seconded or does not move forward.

In order to automate this when creating the meeting agenda it is useful if people respect a standard syntax for that so I can machine parse the issue comments and with a bit of regexps extract the relevant info.

Current message when opening a MCP:

screenshot-20231113-150350

The new version should look like this

screenshot-20231113-150509

Note: the @rustbot syntax here won't trigger anything, It's just a psychological trick to make it look like that a command is executed but in reality it's just to facilitate the machine parsing for me.

Idea mentioned on Zulip.

Documentation update for forge.rust-lang.org: rust-lang/rust-forge#709

Thanks for looking at this patch!

r? @Mark-Simulacrum / @ehuss

@apiraino
Copy link
Contributor Author

hey gentle ping: could this be useful?

cc: @Mark-Simulacrum / @ehuss

thanks

@Mark-Simulacrum
Copy link
Member

I'm not a huge fan of not triggering anything in response to the (fake) command. Are we going to post an error?

@rustbot concern foo bar baz

@Mark-Simulacrum
Copy link
Member

I guess no error. I think this is fine but maybe we can say a bit more instead of register - e.g., "formally declare an objection"? It might also be good to have docs we can link to on the actual process here - e.g., should folks clear the concern somehow?

@apiraino
Copy link
Contributor Author

apiraino commented Nov 28, 2023

I agree. It's a hack and not particularly very elegant. But if you think that providing enough context and documentation makes it palatable, I'm happy to do that!

@Mark-Simulacrum
Copy link
Member

Yep, I'm happy to merge with some extra context (in the comment or in some doc we link to about the process as a whole).

@apiraino apiraino force-pushed the add-detail-to-raise-mcp-concerns branch from 787df4b to 4fe1a9a Compare November 28, 2023 16:19
@apiraino
Copy link
Contributor Author

apiraino commented Nov 28, 2023

ok @Mark-Simulacrum updated the text (hope I got the newlines right), the syntax we will be suggesting reflects the FCP one:

@rustbot concern reason-for-concern

<description of the concern>

and

@rustbot resolve reason-for-concern

Updated the documentation at the forge: rust-lang/rust-forge#709

@apiraino
Copy link
Contributor Author

apiraino commented Dec 7, 2023

@Mark-Simulacrum gentle nudge. thanks.

@Mark-Simulacrum Mark-Simulacrum merged commit 92c3399 into rust-lang:master Dec 7, 2023
2 checks passed
@apiraino apiraino deleted the add-detail-to-raise-mcp-concerns branch December 8, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants