-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detail about how to raise MCP concerns #1747
Add detail about how to raise MCP concerns #1747
Conversation
hey gentle ping: could this be useful? cc: @Mark-Simulacrum / @ehuss thanks |
I'm not a huge fan of not triggering anything in response to the (fake) command. Are we going to post an error? @rustbot concern foo bar baz |
I guess no error. I think this is fine but maybe we can say a bit more instead of register - e.g., "formally declare an objection"? It might also be good to have docs we can link to on the actual process here - e.g., should folks clear the concern somehow? |
I agree. It's a hack and not particularly very elegant. But if you think that providing enough context and documentation makes it palatable, I'm happy to do that! |
Yep, I'm happy to merge with some extra context (in the comment or in some doc we link to about the process as a whole). |
787df4b
to
4fe1a9a
Compare
ok @Mark-Simulacrum updated the text (hope I got the newlines right), the syntax we will be suggesting reflects the FCP one:
and
Updated the documentation at the forge: rust-lang/rust-forge#709 |
@Mark-Simulacrum gentle nudge. thanks. |
During the weekly T-compiler triage meetings we list all MCPs in different stages of progress. Some of them are blocked on concerns not yet resolved. We would like to list these open concerns so that meeting attendees have a glance why an MCP is not seconded or does not move forward.
In order to automate this when creating the meeting agenda it is useful if people respect a standard syntax for that so I can machine parse the issue comments and with a bit of regexps extract the relevant info.
Current message when opening a MCP:
The new version should look like this
Note: the
@rustbot
syntax here won't trigger anything, It's just a psychological trick to make it look like that a command is executed but in reality it's just to facilitate the machine parsing for me.Idea mentioned on Zulip.
Documentation update for forge.rust-lang.org: rust-lang/rust-forge#709
Thanks for looking at this patch!
r? @Mark-Simulacrum / @ehuss