Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): dont create labels if missing #1873

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

weihanglo
Copy link
Member

This is quite annoying if the target repo doesn't need those labels, or have a completely different label management approach.

While issues need to relabel anyway after transfer, it requires more steps to delete a label. I don't think it is worth.

Alternatively, we could have an argument @rustbot transfer cargo createMissingLabels=1 in the future, if people really want missing labels created.

This is quite annoying if the target repo doesn't need those labels,
or have a completely different label management approach.
@weihanglo
Copy link
Member Author

And according to the triagebot doc:

WARNING: Transferring is a partially destructive command. For example, labels and milestones that don’t exist in the target repository will be removed from the issue.

@weihanglo
Copy link
Member Author

Another alternative: configuring via the [transfer] table.

[transfer]
create-labels-if-missing = true

@apiraino
Copy link
Contributor

This was introduced in #1780 and I don't see a specific discussion about labels, therefore I think it's ok to experiment with not migrating labels. I guess the reasoning is that labelling is very specific to the git repository and the workflow of maintainers working there, so there is very little overlap between codebases about labels.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't remember what happened here. That was not the behavior I intended. Perhaps I was testing things and forgot to change it back?

@ehuss ehuss merged commit 0674aa2 into rust-lang:master Dec 31, 2024
2 checks passed
@weihanglo weihanglo deleted the dont-create-label branch December 31, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants