github: fix "Generate next docker tag" log output #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current output of the "Generate next docker tag" step is:
Run echo "VERSION=$(./docker.sh print-next-version)" >> $GITHUB_ENV
Next version to be published is:
The next version is not printed, because `$GITHUB_ENV` is loaded at
the next step. So at this point we cannot access variables that we
are setting in this step.
Use a temporary NEXT_VERSION variable where we save the next version
to print it correctly.
Signed-off-by: Stefano Garzarella <[email protected]>
stefano-garzarella
requested review from
andreeaflorescu,
lauralt,
stsquad,
roypat and
ShadowCurse
as code owners
roypat
approved these changes
Jul 24, 2024
alxiord
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The current output of the "Generate next docker tag" step is:
The next version is not printed, because
$GITHUB_ENVis loaded at the next step. So at this point we cannot access variables that we are setting in this step.Use a temporary NEXT_VERSION variable where we save the next version to print it correctly.