Make StringVal stop at first NULL #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously StringVal would return the raw value of the tag without any stripping of NULL. For special fields like Copyright etc, the value can still be accessed through Val.
|
@op It seems the author is not very active in this project anymore, many forks have been created. I would like to make this stable and I created goexif2 which integrates your patch: xor-gate@34c409c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit unsure what the best solution for ASCII fields are but this feels like a sane approach for most fields. Previously
StringVal()would return the raw value of the tag without any stripping of\x00.For special fields like eg. Copyright, this doesn't work perfectly and a user would need to access the
.Val. Though, I think the API makes more sense now since it will return the string value.For the
MakerNotetest case change, it seems like that particular image is encoded withMakerNoteasASCIIcompared to all the others which are encoded asUndefinedwhich is the expected.