Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add climate support #48

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Add climate support #48

merged 2 commits into from
Nov 3, 2023

Conversation

caibinqing
Copy link
Contributor

Try adding climate support, but not tested.

@caibinqing caibinqing marked this pull request as draft October 25, 2023 02:18
@caibinqing caibinqing marked this pull request as ready for review October 26, 2023 02:02
Copy link
Owner

@rxwen rxwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest update some naming of const

@@ -27,7 +27,8 @@
PROFILE_YAN_BUTTON = 6
PROFILE_SMART_DIAL = 7
PROFILE_COLOR_LIGHT = 8

# PROFILE_9 = 9 # 中央空调控制器
PROFILE_10 = 10 # 中央空调分机
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest rename to PROFILE_AC_UNIT_MACHINE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, renamed

from ..const import (
PROFILE_10,
PROFILE_11_LOCK,
PROFILE_18,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest rename to PROFILE_OCCUPANCY_SENSOR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed PROFILE_18 to PROFILE_OCCUPANCY_SENSOR

@rxwen rxwen merged commit f64d7a2 into rxwen:main Nov 3, 2023
2 checks passed
@caibinqing caibinqing deleted the climate branch November 3, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants