feat: return PROPFIND properties indexed by status #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1519 +/- ##
=========================================
Coverage 97.22% 97.22%
- Complexity 2831 2834 +3
=========================================
Files 175 175
Lines 9010 9018 +8
=========================================
+ Hits 8760 8768 +8
Misses 250 250 ☔ View full report in Codecov by Sentry. |
|
This works fine for the ocis-php-sdk, see owncloud/ocis-php-sdk#117 |
@individual-it then are you happy that we can go with this data structure being returned? |
This returns all the properties received in the server response, even for resources that have a status that is not 200 (success).
phil-davis
force-pushed
the
issue-1041-alternate-a
branch
from
1eb5cf2 to
add4a14
Compare
|
@phil-davis yes, if this can be merged and release it will help me a lot |
staabm
reviewed
Dec 11, 2023
|
@staabm please review again |
staabm
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of PR #1518
See the latest commit - it returns the PROPFIND data keyed by status. All the items with status
200are in an array with key200, all the items with status400are in an array with key400.That simplifies the code a bit, and avoids having the keywords "properties" and "status'.
I'm not sure if this is a better way or not.