Transition to poetry + address numpy 2.0 and numba 0.60 related issues
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
deeenes
changed the title
np.arange: do not pass start as kwargpoetry + address numpy 2.0 and numba 0.60 related issues
|
Hey @PauBadiaM, I think this is ready to merge, I bumped the version number and I would update it also in PyPI to avoid a flood of issues in the upcoming weeks :) |
|
Looks fantastic @deeenes! Thanks for taking care of this really. Just one last thing, I see poetry failing for all ubuntu's CI. Maybe you could instead of using the cached version just install it, it should not take long (as it is done in liana-py: https://github.com/saezlab/liana-py/blob/main/.github/workflows/main.yml). But feel free to keep the cached version if you manage to make it work. |
|
@PauBadiaM You're right, I removed the caching of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because numba fails the function signature check in Py 3.11