Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Jitsi as a PlatformView #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kamskr
Copy link

@kamskr kamskr commented Mar 28, 2023

Hello!

This PR attempts to implement changes discussed in #36.
I took the changes proposed by @geiszla in https://github.com/BindrUK/jitsi_meet/tree/platform-view

In addition to iOS NativeView implementation this changes also contain:

I'm still working on the Android part as it's much more tricky than the iOS part. I tried to implement changes from the fork mentioned above but so far failed to get it working as ReactNative parts seem to be outdated.

I also tried to embed it directly but I was not able to do that with the need for wrapping the JitsiMeetView in JitsiMeetActivity.

Notice that I temporarily changed the pubspec.yaml to relative import of jitsi_meet_wrapper_platform_interface. As the changes are in both packages I left it for testing purposes.

This is still work in progress, I will continue implementing the missing android part, but I'm looking forward for any feedback/suggestions/support as my android knowledge is quite limited.

Thank you

@predictron-cloud
Copy link

@kamskr, Did you have a chance to finish the android part? Maybe you have some version of android code that you can commit to some another branch and I can try to fix finish this work?

@kamskr
Copy link
Author

kamskr commented Sep 15, 2023

@predictron-cloud

Unfortunately, I was not able to get it to work on Android. I don't have any progress that would be useful and is not already in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants