chore: test usage of default slot with scoped data #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
approved these changes
Dec 9, 2024
cardoso
reviewed
Dec 9, 2024
| @@ -0,0 +1,9 @@ | |||
| <template> | |||
| <x-child> | |||
| <!-- TODO [#5020]: Fix rendering of scoped slot content, so that content outside of the template renders correctly with engine-server --> | |||
There was a problem hiding this comment.
This comment is great! I have a feeling there are other tests added recently which are expected failures of engine-server but aren't documented as such and only in PR comments.
wjhsf
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add specific coverage for scoped default slots (currently,
engine-serverdoes not render all content, see #5020)Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?