feat(engine): support imperative wire adapters #5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Expand the allowed types for
wiredecorators to support objects that have anadapterprop holding the WireAdapterConstructor. Examples of this being Apex functions imported from the Salesforce platform. They are function objects that can be called imperatively and also have anadapterprop holding a compatible WireAdapterConstructor that can be passed to thewiredecorator.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
Expand the type compatibility for the
wiredecorator to allow a wire adapter constructor delivered as a prop. This should only expand the allowed types, not constrain them and shouldn't result in any breaks for consumers.