fix(ssr): remove dev-only accessor warnings #5135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jan 14, 2025
| @@ -1,6 +1,6 @@ | |||
| <x-component> | |||
| <template shadowrootmode="open"> | |||
| <x-child aria-activedescendant="foo" aria-atomic="foo" aria-autocomplete="foo" aria-busy="foo" aria-checked="foo" aria-colcount="foo" aria-colindex="foo" aria-colspan="foo" aria-controls="foo" aria-current="foo" aria-describedby="foo" aria-details="foo" aria-disabled="foo" aria-errormessage="foo" aria-expanded="foo" aria-flowto="foo" aria-haspopup="foo" aria-hidden="foo" aria-invalid="foo" aria-keyshortcuts="foo" aria-label="foo" aria-labelledby="foo" aria-level="foo" aria-live="foo" aria-modal="foo" aria-multiline="foo" aria-multiselectable="foo" aria-orientation="foo" aria-owns="foo" aria-placeholder="foo" aria-posinset="foo" aria-pressed="foo" aria-readonly="foo" aria-relevant="foo" aria-required="foo" aria-roledescription="foo" aria-rowcount="foo" aria-rowindex="foo" aria-rowspan="foo" aria-selected="foo" aria-setsize="foo" aria-sort="foo" aria-valuemax="foo" aria-valuemin="foo" aria-valuenow="foo" aria-valuetext="foo" exportparts="foo" role="foo"> | |||
| <x-child accesskey="foo" aria-activedescendant="foo" aria-atomic="foo" aria-autocomplete="foo" aria-busy="foo" aria-checked="foo" aria-colcount="foo" aria-colindex="foo" aria-colspan="foo" aria-controls="foo" aria-current="foo" aria-describedby="foo" aria-details="foo" aria-disabled="foo" aria-errormessage="foo" aria-expanded="foo" aria-flowto="foo" aria-haspopup="foo" aria-hidden="foo" aria-invalid="foo" aria-keyshortcuts="foo" aria-label="foo" aria-labelledby="foo" aria-level="foo" aria-live="foo" aria-modal="foo" aria-multiline="foo" aria-multiselectable="foo" aria-orientation="foo" aria-owns="foo" aria-placeholder="foo" aria-posinset="foo" aria-pressed="foo" aria-readonly="foo" aria-relevant="foo" aria-required="foo" aria-roledescription="foo" aria-rowcount="foo" aria-rowindex="foo" aria-rowspan="foo" aria-selected="foo" aria-setsize="foo" aria-sort="foo" aria-valuemax="foo" aria-valuemin="foo" aria-valuenow="foo" aria-valuetext="foo" dir="foo" draggable="foo" exportparts="foo" id="foo" lang="foo" role="foo" spellcheck="foo" tabindex="foo" title="foo"> | |||
There was a problem hiding this comment.
This is still not 100% right, but it's at least closer to what engine-dom does. What it's still missing is that, in the browser, there is some built-in massaging here – draggable for example should be massaged to "true".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a step towards fixing #5134 and #5123. It removes some dev-only accessors when running in SSR mode.
The problem here is multi-fold. First off, this filter:
lwc/packages/@lwc/engine-core/src/framework/base-bridge-element.ts
Line 169 in 095a777
...basically does nothing in SSR, because
HTMLElementPrototypeis empty:lwc/packages/@lwc/engine-core/src/framework/html-element.ts
Lines 9 to 10 in 095a777
So this causes us to always add dev-only accessors for e.g.
title,tabIndex, etc.Next up, the renderer does an
incheck here:lwc/packages/@lwc/engine-server/src/renderer.ts
Line 192 in 095a777
This is always true for
title,tabIndex, etc., since the accessors were added in dev mode. So this leads totitle/tabIndex/etc. differing between SSR and CSR (or between prod mode and dev mode).In general, I'm starting to wonder if these dev-only accessors are even worth it anymore – they've caused a lot of headaches, and the only value is that you get a nice warning when you forget to add an
@api. But for now we can at least disable them in SSR.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item