[Caracal] Migrate github workflow and Fix Tests #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-rosenzweig
force-pushed
the
migrate_tox_fix_unit_tests
branch
5 times, most recently
from
1e66afc to
11df9b4
Compare
|
sven-rosenzweig
force-pushed
the
migrate_tox_fix_unit_tests
branch
from
11df9b4 to
c80b101
Compare
sven-rosenzweig
requested review from
joroaf and
notandy
and removed request for
joroaf
Before loading the NSX-T Operation API default configuration settings must be loaded as of part of the version migration. Remove the subnetpool in the DB unit tests as this is not needed for a subnet creation. Without the subnetpool, the db unit test test_port_sg fails as the result of a DB query returns the cartesian product between the tables SecurityGroupPortBindings and StandardAttributes. Thus the length of the result set is lowered from 9 to 8 as there are only 8 objects with standard attributes. This is a minor bug which will be fixed in a separate PR.
Loosen constraints for the installation of neutron and neutron-lib in the test-requirements.txt as the upper bound was set to Neutron Yoga release. Within the tox configuration request the installation of yoga from the current stable/2024.1-m3 branch. As Tox version 4 treats '#' as comments a '\' is required. Change base branch to Caracal release. Furthermore set the base python version to 3.10. Update the github-runner to the latest version, as the reason for sticking to an older version is no longer true. Loosen constraints for the VIRTUALENV_PIP version. Sticking with pinned version causes the tox execution to fail.
Sqlalchemy has become more strict, the second argument would need to be a column or an expression, not another object
Apparently for sqlalchemy 2.0, using the decorators is mandatory
Apparently some time in the past, the automatic adding of options during import have been replaced by the explicit registration via a function call
In recent time, the automatic import of all config files has been refactored to selective import, so we have to do it now by hand.
sven-rosenzweig
force-pushed
the
migrate_tox_fix_unit_tests
branch
from
16be2e5 to
e72ebd5
Compare
notandy
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change python version and basebranch according to the Caracal release to
version 3.10 and 2024.1-m3.
Loosen constraints for the installation of neutron and
neutron-lib in the test-requirements.txt as the upperbound was set to
Neutron Yoga release. Within the tox configuration request the
installation of yoga from the current stable/2024.1-m3 branch.
For the DB unit tests remove the subnetpool as this is not needed for
a subnet creation. Without the subnetpool, the db unit test test_port_sg
fails as the result of a DB query returns the cartesian product between
the tables SecurityGroupPortBindings and StandardAttributes. Thus the
length of the result set is lowered from 9 to 8.
This is a minor bug which will be fixed in a separate PR.