-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenge 7 svg nft init #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks and works great!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ @rin-st!! It's looking good to me. And thanks @damianmarti for the great base 🙌
Pushed some minor changes to the Readme and tweaked RWD a bit. Feel free to change or undo anything you don't like pls!
Maybe for future iterations:
- Would be cool to have a section after the "Quest Journal", showcasing the most interesting technical points of the Challenge. Like we had in the Multisig-break-down
- Should we add a couple of loogie images to the hero section of /loogies ? Too much text and we don't see a loogie until we mint some. But maybe not worth it since is just an example!
Thanks Pablo! Good changes!
I added one simple svg above the h1 in |
Looking better with the loogies you added :) I've deleted the base test in 29ddccb. Not sure if deleting the test file is enough, or if there is some file that needs to be updated too. |
Yes, it's enough, thanks! |
Thank you @Pabl0cks and @damianmarti, merging this! |
SVG NFT Challenge based on Loogies example.
I'm not very good at writing texts so feel free to discuss/change/share your ideas etc about README.md and the main page.tsx
Also, text on SpeedRunEthereum.com should be changed. Created PR BuidlGuidl/SpeedRunEthereum#203 but currently in draft
And, we can also change images since it's other loogies, but we can do it later
Thanks @Pabl0cks for the idea and @damianmarti for your example and quick migration to SE-2!
I think we need to invite Austin to review texts and app but later when it is polished better