Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge 7 svg nft init #184

Merged
merged 17 commits into from
Jun 13, 2024
Merged

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Jun 5, 2024

SVG NFT Challenge based on Loogies example.

I'm not very good at writing texts so feel free to discuss/change/share your ideas etc about README.md and the main page.tsx

Also, text on SpeedRunEthereum.com should be changed. Created PR BuidlGuidl/SpeedRunEthereum#203 but currently in draft

And, we can also change images since it's other loogies, but we can do it later

Thanks @Pabl0cks for the idea and @damianmarti for your example and quick migration to SE-2!

I think we need to invite Austin to review texts and app but later when it is polished better

Copy link
Member

@damianmarti damianmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks and works great!!

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ @rin-st!! It's looking good to me. And thanks @damianmarti for the great base 🙌

Pushed some minor changes to the Readme and tweaked RWD a bit. Feel free to change or undo anything you don't like pls!

Maybe for future iterations:

  • Would be cool to have a section after the "Quest Journal", showcasing the most interesting technical points of the Challenge. Like we had in the Multisig-break-down
  • Should we add a couple of loogie images to the hero section of /loogies ? Too much text and we don't see a loogie until we mint some. But maybe not worth it since is just an example!

@rin-st
Copy link
Member Author

rin-st commented Jun 12, 2024

Thanks Pablo! Good changes!

Would be cool to have a section after the "Quest Journal", showcasing the most interesting technical points of the Challenge. Like we had in the Multisig-break-down

#185

Should we add a couple of loogie images to the hero section of /loogies ? Too much text and we don't see a loogie until we mint some. But maybe not worth it since is just an example!

I added one simple svg above the h1 in /loogies and /your-loogies (probably we need to change it to my-loogies) but left it as it was originally. Also made paddings smaller so I can see first row of nfts at least on my notebook

Снимок экрана 2024-06-12 в 13 29 41 Снимок экрана 2024-06-12 в 13 30 03

@Pabl0cks
Copy link
Collaborator

I added one simple svg above the h1 in /loogies and /your-loogies (probably we need to change it to my-loogies) but left it as it was originally. Also made paddings smaller so I can see first row of nfts at least on my notebook

Looking better with the loogies you added :)

I've deleted the base test in 29ddccb. Not sure if deleting the test file is enough, or if there is some file that needs to be updated too.

@rin-st
Copy link
Member Author

rin-st commented Jun 13, 2024

I've deleted the base test in 29ddccb. Not sure if deleting the test file is enough, or if there is some file that needs to be updated too.

Yes, it's enough, thanks!

@rin-st rin-st requested review from austintgriffith and removed request for austintgriffith June 13, 2024 11:42
@rin-st
Copy link
Member Author

rin-st commented Jun 13, 2024

Thank you @Pabl0cks and @damianmarti, merging this!

@rin-st rin-st merged commit 8d37783 into challenge-7-svg-nft Jun 13, 2024
@rin-st rin-st deleted the challenge-7-svg-nft-init branch June 13, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants