Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update Docusaurus from 3.2.1 to 3.4.0" #284

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

josh-wong
Copy link
Member

@josh-wong josh-wong commented Jun 11, 2024

Description

This PR reverts Docusaurus from v3.4.0 to v3.2.1. Both versions have the following issues regarding Algolia DocSearch:

  • v3.2.1
    • When searching the docs site by using Algolia DocSearch, selecting the section heading of a page, and then pressing Ctrl + F to search the page, the page becomes unresponsive and must be refreshed in order for users to navigate the page.
  • v3.4.0
    • When searching the docs site by using Algolia DocSearch, selecting the section heading of a page, and then pressing Ctrl + F to search the page, a key binding issue occurs that causes the Algolia DocSearch modal to open and search for the letter f instead of the browser opening its built-in “Find” function, which is standard behavior. Users must then click outside of the modal window to close it, or they must click elsewhere on the screen before pressing Ctrl + F to use the "Find" function on the page.

Related issues and/or PRs

Changes made

  • Reverted the changes dependencies for Docusaurus back to v3.2.1.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have updated the side navigation as necessary.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@josh-wong josh-wong added the bug Something isn't working label Jun 11, 2024
@josh-wong josh-wong self-assigned this Jun 11, 2024
@josh-wong josh-wong changed the title Revert "Update Docusaurus from 3.2.1 to 3.4.0 (#283)" Revert "Update Docusaurus from 3.2.1 to 3.4.0" Jun 11, 2024
@josh-wong josh-wong merged commit f4c53b0 into main Jun 11, 2024
1 check passed
@josh-wong josh-wong deleted the revert-docusaurus-to-3.2 branch June 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant