This repository has been archived by the owner on Nov 26, 2019. It is now read-only.
update logger to a non-yanked version #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahi/logger#3 This is just the result of running `bundle update --conservative logger`. Based on above issue, I _think_ 1.3.0 is equivalent to 1.2.8 that we were using before, now yanked. This comes up only because our `jettywrapper` dependency has an explicit dependency on `logger`. `Logger` is a part of stdlib, and doens't really need an explicit dependency. But it was also released as a separate gem to rubygems -- perhaps accidentally? Perhaps @nahi trying to clean that up after 7 years is why it was yanked? I don't entirely understand what was going on, but the yanking of 1.2.8 will cause a problem for anyone that has an explicit `logger` dependency in their dependency tree, as we did/do. We have no easy way to remove the explicit dependency, unless we stop using `jettywrapper`, which I'm not sure if we can or not. Easiest fix to make the app deployable and buildable again seems to be this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nahi/logger#3
This is just the result of running
bundle update --conservative logger.Based on above issue, I think 1.3.0 is equivalent to 1.2.8 that we were using before, now yanked.
This comes up only because our
jettywrapperdependency has an explicit dependency onlogger.Loggeris a part of stdlib, and doens't really need an explicit dependency. But it was also released as a separate gem to rubygems -- perhaps accidentally? Perhaps @nahi trying to clean that up after 7 years is why it was yanked? I don't entirely understand what was going on, but the yanking of 1.2.8 will cause a problem for anyone that has an explicitloggerdependency in their dependency tree, as we did/do. We have no easy way to remove the explicit dependency, unless we stop usingjettywrapper, which I'm not sure if we can or not.Easiest fix to make the app deployable and buildable again seems to be this.