Enabling double precision real number #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging @mnijh's "add_activation_functions" (https://github.com/mnijh/FKB/tree/add_activation_functions)
…oating point overflow (esp. when using single precision)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default precision for real number is 32-bit in FKB. However, we found that this 32-bit is not enough for our application (e.g., floating point overflow/underflow), and 64-bit is needed. The original FKB is written to support 64-bit or 128-bit real number, but there were minor bugs. Also, there were bugs when 64-bit integer is selected. This is a debugged version that successfully compiles with -DREAL64, -DREAL128, or -DINT64 flags.