Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove problematic try/finally block #137

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

effigies
Copy link
Collaborator

I'm not sure there's a good test to write here. You could mock inspect.stack, but what assertions would there be worth making?

Closes #136.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (4e78314) to head (683f722).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   95.74%   95.72%   -0.02%     
==========================================
  Files           5        5              
  Lines         235      234       -1     
==========================================
- Hits          225      224       -1     
  Misses         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies added the type: Bug fix Something isn't working label Dec 20, 2024
@stefanv
Copy link
Member

stefanv commented Dec 20, 2024

So what happens now when the parent assignment fails, which, I presume, is what caused the original issue?

@effigies
Copy link
Collaborator Author

An exception is raised, and there's nothing to delete before letting the exception propagate.

@stefanv stefanv merged commit 245767a into scientific-python:main Dec 21, 2024
29 of 30 checks passed
@jarrodmillman jarrodmillman added this to the 0.5 milestone Dec 21, 2024
@stefanv
Copy link
Member

stefanv commented Dec 21, 2024

Thank you, @effigies!

@effigies effigies deleted the fix/unbound-parent branch December 21, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnboundLocalError appeared in lazy-loader 0.4
4 participants