Skip to content

Commit

Permalink
[TEST] Add logging to understand amendment flapping bug
Browse files Browse the repository at this point in the history
  • Loading branch information
scottschurr committed Oct 26, 2023
1 parent 5af9dc5 commit 0619fe6
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions src/ripple/app/consensus/RCLConsensus.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,13 @@ RCLConsensus::Adaptor::onClose(
app_.getAmendmentTable().doVoting(
prevLedger, validations, initialSet);
}
else
{
JLOG(j_.debug())
<< "AmendmentTable::doVoting() not called. "
<< "validations < quorum (" << validations.size() << " < "
<< app_.validators().quorum() << ")";
}
}
else if (
prevLedger->isVotingLedger() &&
Expand All @@ -364,6 +371,16 @@ RCLConsensus::Adaptor::onClose(
initialSet);
}
}
else
{
if (prevLedger->isFlagLedger())
{
JLOG(j_.debug())
<< "AmendmentTable::doVoting() not called. "
<< "StandAlone: " << app_.config().standalone()
<< "; proposing: " << proposing << "; wrongLCL: " << wrongLCL;
}
}

// Now we need an immutable snapshot
initialSet = initialSet->snapShot(false);
Expand Down

0 comments on commit 0619fe6

Please sign in to comment.