feat: enforced batch mode #68
Open
+859
−1,590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimpha
force-pushed
the
feat/enforced-batch
branch
from
8612778 to
aee35b9
Compare
zimpha
force-pushed
the
feat/enforced-batch
branch
from
aee35b9 to
d851e8e
Compare
jonastheis
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
LGTM!
with the new batch design this will need to change again but the main mechanism of
- track time of latest finalized batch
- if too much time elapsed allow anyone to commit batch + proof and disallow sequencer to submit via usual methods
- only allow security council to deactivate this enforced/permissionless mode
should stay the same and just the interface of what/how a batch needs to be passed should change.
| @@ -46,6 +46,15 @@ library BatchHeaderV3Codec { | |||
| } | |||
| } | |||
|
|
|||
| /// @notice Get the blob versioned hash of the batch header. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.