-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Bridge API and add recommended RPC flag #378
base: develop
Are you sure you want to change the base?
Conversation
isabellewei
commented
Oct 25, 2024
- remove Bridge API endpoint, use Bridge SDK instead
- add gpo flag to node runner guide
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -68,7 +68,8 @@ Please consider opening port `30303`(UDP & TCP) and enabling discovery so that o | |||
--datadir "./l2geth-datadir" \ | |||
--gcmode archive --cache.noprefetch \ | |||
--http --http.addr "0.0.0.0" --http.port 8545 --http.api "eth,net,web3,debug,scroll" \ | |||
--l1.endpoint "$L2GETH_L1_ENDPOINT" --rollup.verify | |||
--l1.endpoint "$L2GETH_L1_ENDPOINT" --rollup.verify \ | |||
--gpo.congestionthreshold=500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new suggested congestionthreshold
should be 200 as discussed at https://scrollco.slack.com/archives/C02PKAQ2430/p1729319394735449?thread_ts=1729291990.648509&cid=C02PKAQ2430
cc @Thegaram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @yiweichi
@@ -117,7 +118,8 @@ Running the node in Docker might have a significant impact on node performance. | |||
--datadir "/volume/l2geth-datadir" \ | |||
--gcmode archive --cache.noprefetch \ | |||
--http --http.addr "0.0.0.0" --http.port 8545 --http.api "eth,net,web3,debug,scroll" \ | |||
--l1.endpoint "$L2GETH_L1_ENDPOINT" --rollup.verify | |||
--l1.endpoint "$L2GETH_L1_ENDPOINT" --rollup.verify \ | |||
--gpo.congestionthreshold=500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @yiweichi -- my guess is we should change this in our SDK RPC values as well?