Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): log utilization #1491

Merged
merged 5 commits into from
Aug 22, 2024
Merged

feat(prover): log utilization #1491

merged 5 commits into from
Aug 22, 2024

Conversation

amoylan2
Copy link
Contributor

Purpose or design rationale of this PR

log utilization

  • add detailed log in main.rs
  • add error log when failed to prove task, such as failed to get trace from l2geth
  • no longer adding error log when prover already knows it's submitting an error

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

colinlyguo
colinlyguo previously approved these changes Aug 21, 2024
@amoylan2 amoylan2 merged commit 517469a into develop Aug 22, 2024
6 checks passed
@amoylan2 amoylan2 deleted the feat/prover_add_log branch August 22, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants