Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): add failure retry on rpc error #994

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Oct 19, 2023

Purpose or design rationale of this PR

add failure retry on more cases, including more HTTP errors, network errors, etc.
code ref: https://github.com/go-resty/resty/blob/v2.10.0/client_test.go#L892

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@colinlyguo colinlyguo self-assigned this Oct 19, 2023
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #994 (c8fb403) into develop (1059f9d) will not change coverage.
The diff coverage is n/a.

❗ Current head c8fb403 differs from pull request most recent head 852f526. Consider uploading reports for the commit 852f526 to get more accurate results

@@           Coverage Diff            @@
##           develop     #994   +/-   ##
========================================
  Coverage    48.13%   48.13%           
========================================
  Files          100      100           
  Lines        10591    10591           
========================================
  Hits          5098     5098           
  Misses        5071     5071           
  Partials       422      422           
Flag Coverage Δ
prover 27.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@0xmountaintop 0xmountaintop merged commit c2ab4bf into develop Oct 19, 2023
@0xmountaintop 0xmountaintop deleted the fix-prover-add-failure-retry branch October 19, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants