use 0 as bn254 scalar nonce. FIX later

scroll-tech · Jun 27, 2024 · 1b558fe · 1b558fe
1 parent e755c43
commit 1b558fe
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/core/src/runtime/syscall.rs b/core/src/runtime/syscall.rs
@@ -467,6 +467,8 @@ mod tests {
                 SyscallCode::BN254_SCALAR_MAC => {
                     assert_eq!(code as u32, sp1_zkvm::syscalls::BN254_SCALAR_MAC)
                 }
+                SyscallCode::MEMCPY_32 => todo!(),
+                SyscallCode::MEMCPY_64 => todo!(),
             }
         }
     }

diff --git a/core/src/syscall/memcpy.rs b/core/src/syscall/memcpy.rs
@@ -204,6 +204,7 @@ impl<AB: SP1AirBuilder, NumWords: ArrayLength + Sync, NumBytes: ArrayLength + Sy
             row.shard,
             row.channel,
             row.clk,
+            AB::F::from_canonical_u32(0u32),
             AB::F::from_canonical_u32(Self::syscall_id()),
             row.src_ptr,
             row.dst_ptr,

diff --git a/core/src/syscall/precompiles/bn254_scalar/mac.rs b/core/src/syscall/precompiles/bn254_scalar/mac.rs
@@ -287,6 +287,7 @@ where
             row.shard,
             row.channel,
             row.clk,
+            AB::F::from_canonical_u32(0u32),
             syscall_id,
             row.arg1_ptr,
             row.arg2_ptr,

diff --git a/core/src/syscall/precompiles/bn254_scalar/mul.rs b/core/src/syscall/precompiles/bn254_scalar/mul.rs
@@ -32,6 +32,7 @@ pub struct Bn254ScalarMulCols<T> {
     shard: T,
     channel: T,
     clk: T,
+    nonce: T,
     p_ptr: T,
     q_ptr: T,
     p_access: [MemoryWriteCols<T>; NUM_WORDS_PER_FE],
@@ -210,6 +211,7 @@ where
             row.shard,
             row.channel,
             row.clk,
+            AB::F::from_canonical_u32(0u32),
             syscall_id,
             row.p_ptr,
             row.q_ptr,